[USDU-275] Adds testcase for checking if export keeps the original data structure #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee-aandrew
requested review from
IlliaKo,
judubu and
vickycl
and removed request for
vickycl
vickycl
reviewed
Feb 2, 2023
Contributor
vickycl
left a comment
vickycl
left a comment
There was a problem hiding this comment.
Is there a reason for making this test a Runtime test? I can't think of a reason not to, but it does seem like exporting in EditMode is a far more common use case, so I'm curious :)
package/com.unity.formats.usd/Tests/Common/CustomAsserts/ExportAssert.cs
Outdated
Show resolved
Hide resolved
lee-aandrew
force-pushed
the
add-test-export-data-structure-kept
branch
from
153f4af to
645cccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ticket/Jira #:
[USDU-275] & [USDU-279]
Testing
ExportAsUsdz_DataStructureKeptOnImport:
Complexity:
1
Halo Effect:
1
Additional information
Note to reviewers:
Reminder: